Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

potential cpu usage improvement for metrics #15478

Closed
lmatz opened this issue Mar 6, 2024 · 2 comments
Closed

potential cpu usage improvement for metrics #15478

lmatz opened this issue Mar 6, 2024 · 2 comments
Assignees
Milestone

Comments

@lmatz
Copy link
Contributor

lmatz commented Mar 6, 2024

From discussion with @Li0k and @Little-Wallace:

when running TPC-H q4 and generating CPU flamegraph: https://buildkite.com/risingwave-test/tpch-benchmark/builds/1014#018e0e57-a87f-4d2c-948a-7e2ecae8b3be

It was found that
SCR-20240306-get
SCR-20240306-gf0
SCR-20240306-gf4
SCR-20240306-gen

Adding all 4 occurrences together, it is about 5% CPU time for metrics. q4 is a relatively simple query with only one join operator. The query can be found here: #14811

@lmatz lmatz added the type/perf label Mar 6, 2024
@github-actions github-actions bot added this to the release-1.8 milestone Mar 6, 2024
@lmatz
Copy link
Contributor Author

lmatz commented Mar 6, 2024

@lmatz
Copy link
Contributor Author

lmatz commented Mar 18, 2024

done by #15488

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants