Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024-02-19 sysbench-select-random-limits-medium-3cn performance regression #15140

Open
lmatz opened this issue Feb 20, 2024 · 13 comments
Open

2024-02-19 sysbench-select-random-limits-medium-3cn performance regression #15140

lmatz opened this issue Feb 20, 2024 · 13 comments
Assignees
Labels
component/batch Batch related related issue. found-by-sysbench-test help wanted Issues that need help from contributors no-issue-activity type/perf

Comments

@lmatz
Copy link
Contributor

lmatz commented Feb 20, 2024

SCR-20240220-dbw

https://buildkite.com/risingwave-test/sysbench/builds/687#

https://risingwave-labs.slack.com/archives/C04R6R5236C/p1708387203780599

@lmatz lmatz added help wanted Issues that need help from contributors component/batch Batch related related issue. type/perf labels Feb 20, 2024
@github-actions github-actions bot added this to the release-1.7 milestone Feb 20, 2024
@lmatz
Copy link
Contributor Author

lmatz commented Feb 20, 2024

@lmatz
Copy link
Contributor Author

lmatz commented Feb 20, 2024

@lmatz
Copy link
Contributor Author

lmatz commented Feb 20, 2024

searched the issue history and the fluctuation happened a while ago: #14022

@cyliu0 did the config change again?
or shall we change it again?
The CPU is right now not fully utilized I suppose,
since BENCH_TESTBED="medium-3cn" and medium machines have 8 cpus while currently only 600% is used.

also cc: @chenzl25

@cyliu0
Copy link
Collaborator

cyliu0 commented Feb 20, 2024

No... we didn't change it since the above issue. It's still 64 threads. Which config would you like to change?
image

@lmatz
Copy link
Contributor Author

lmatz commented Feb 20, 2024

Which config would you like to change?

I am curious about the story behind why we changed the thread number in the previous issue: #14022

And also how was it determined that the problem was gone last time?

@cyliu0
Copy link
Collaborator

cyliu0 commented Feb 20, 2024

Which config would you like to change?

I am curious about the story behind why we changed the thread number in the previous issue: #14022

Originally from here https://risingwave-labs.slack.com/archives/C03GTKX3C8G/p1702015068556349

And also how was it determined that the problem was gone last time?

+1 @chenzl25

@lmatz
Copy link
Contributor Author

lmatz commented Feb 20, 2024

Originally from here https://risingwave-labs.slack.com/archives/C03GTKX3C8G/p1702015068556349

thanks, I see, but I feel that not reaching full CPU usage is independent of having fluctuation, just cannot think of a possible cause that can relate these two phenomenon at the moment

@chenzl25
Copy link
Contributor

chenzl25 commented Feb 21, 2024

Maybe we can increase the threads number for this test? because its performance is better than before now and our resources are not fully utilized/

@lmatz
Copy link
Contributor Author

lmatz commented Feb 21, 2024

Maybe we can increase the threads number for this test? because its performance is better than before now and our resources are not fully utilized/

increase the sys_threads from 64 to an even larger number, e.g. 128 cc: @cyliu0 , could you run the new setting once, let's see if CPU can be fully utilized under such setting

@cyliu0
Copy link
Collaborator

cyliu0 commented Feb 23, 2024

The highest one 10667.46 is the 128 threads result https://buildkite.com/risingwave-test/sysbench/builds/689#018dc9f0-aa60-45d3-94c8-7848b15bc601

image

@cyliu0
Copy link
Collaborator

cyliu0 commented Mar 1, 2024

It's still not stable after we changed the threads to 128 in daily test. http://metabase.risingwave-cloud.xyz/dashboard/278-sysbench-rw-qps
image

@cyliu0 cyliu0 modified the milestones: release-1.7, release-1.8 Mar 6, 2024
@lmatz lmatz removed this from the release-1.8 milestone Mar 6, 2024
Copy link
Contributor

This issue has been open for 60 days with no activity. Could you please update the status? Feel free to continue discussion or close as not planned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/batch Batch related related issue. found-by-sysbench-test help wanted Issues that need help from contributors no-issue-activity type/perf
Projects
None yet
Development

No branches or pull requests

3 participants