Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: reuse single_node mode for playground and standalone #14997

Closed
kwannoel opened this issue Feb 5, 2024 · 6 comments
Closed

Refactor: reuse single_node mode for playground and standalone #14997

kwannoel opened this issue Feb 5, 2024 · 6 comments

Comments

@kwannoel
Copy link
Contributor

kwannoel commented Feb 5, 2024

  • Add a profile for playground.
  • Add a profile for standalone mode.
  • Cloud needs to use the new standalone profile.
  • Docs need to be updated to use the new playground profile via single_node.
  • Docker needs to use the new standalone profile.
@github-actions github-actions bot added this to the release-1.7 milestone Feb 5, 2024
@kwannoel
Copy link
Contributor Author

kwannoel commented Feb 5, 2024

See #14951 (review)

@xxchan
Copy link
Member

xxchan commented Feb 7, 2024

What about the naming? I quite like --preset in-memory/local-disk (or --profile) proposed here #14951 (review).

And maybe we can reuse standalone as the command name? (just like implement the map_opts feature directly on top of old standalone mode.

@kwannoel
Copy link
Contributor Author

kwannoel commented Feb 7, 2024

What about the naming? I quite like --preset in-memory/local-disk (or --profile) proposed here #14951 (review).

Yes, profile.

And maybe we can reuse standalone as the command name? (just like implement the map_opts feature directly on top of old standalone mode.

Yes, after we deprecate standalone, we can use single-node as an alias, and rename it to standalone.

@xxchan
Copy link
Member

xxchan commented Feb 7, 2024

Yes, profile.

I mean the profiles' names. e.g., I like in-memory better than playground 🥺

@kwannoel
Copy link
Contributor Author

kwannoel commented Feb 7, 2024

Yes, profile.

I mean the profiles' names. e.g., I like in-memory better than playground 🥺

Yes, I prefer:

  • in-memory (playground)
  • persistent (single-node)

For standalone mode, can just choose either and supply extra-args for further configuration.

@fuyufjh
Copy link
Member

fuyufjh commented Feb 22, 2024

We may remove playground mode in the future. Users who want to take a try of RW can just use single-node mode.

Discussing here https://risingwave-labs.slack.com/archives/C05TXGYUL6N/p1708578235388599?thread_ts=1707372310.943919&cid=C05TXGYUL6N

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants