Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and publish RisingWave binaries for linux arm64 #14898

Closed
kwannoel opened this issue Jan 31, 2024 · 9 comments
Closed

Build and publish RisingWave binaries for linux arm64 #14898

kwannoel opened this issue Jan 31, 2024 · 9 comments
Assignees
Milestone

Comments

@kwannoel
Copy link
Contributor

No description provided.

@kwannoel kwannoel changed the title Build and publish binaries for osx arm64, linux arm64, osx x86_64. Build and publish RisingWave binaries for osx arm64, linux arm64, osx x86_64. Jan 31, 2024
@github-actions github-actions bot added this to the release-1.7 milestone Jan 31, 2024
@kwannoel
Copy link
Contributor Author

I think this could be a blocker before we can publish the install script. Otherwise other common architectures will not be supported.

Marking it as priority:high

@huangjw806
Copy link
Contributor

Do we need to release the binary of osx?

@kwannoel
Copy link
Contributor Author

kwannoel commented Feb 1, 2024

Do we need to release the binary of osx?

Yes, many users may try it out on their local machine.
Any difficulties?

@huangjw806
Copy link
Contributor

huangjw806 commented Feb 1, 2024

Any difficulties?

@BugenZhao has compiled a binary for mac os before, but he said it doesn’t necessary. I think one of the reasons is that cloud costs more.

@kwannoel
Copy link
Contributor Author

kwannoel commented Feb 1, 2024

Any difficulties?

@BugenZhao has compiled a binary for mac os before, but he said it doesn’t necessary. I think one of the reasons is that cloud costs more.

We run it once per release, so should be fine?

@BugenZhao
Copy link
Member

I'm not sure what the motivation of this feature request is... 😕 Can you elaborate more? From my understanding...

  • For macOS, users can install RisingWave directly with brew install risingwave to download the prebuilt binaries. If one doesn't want it to be in the PATH, run brew unlink.
  • For aarch64 Linux, I guess it's worth to have as we only need to duplicate the workflow for x86_64 linux.

Regarding the installation script, it appears to be an os/arch detector that redirects users to different download targets. I haven't found much necessity for this. macOS users can brew install, while Linux users I believe are accustomed to finding and downloading the binary directly. 🤣

@kwannoel
Copy link
Contributor Author

kwannoel commented Feb 2, 2024

I'm not sure what the motivation of this feature request is... 😕 Can you elaborate more? From my understanding...

* For macOS, users can install RisingWave directly with `brew install risingwave` to download the prebuilt binaries. If one doesn't want it to be in the `PATH`, run `brew unlink`.

* For aarch64 Linux, I guess it's worth to have as we only need to duplicate the workflow for x86_64 linux.

Regarding the installation script, it appears to be an os/arch detector that redirects users to different download targets. I haven't found much necessity for this. macOS users can brew install, while Linux users I believe are accustomed to finding and downloading the binary directly. 🤣

Single install script seems most convenient.

@huangjw806 we can just use brew for macOS users, so it should be fine. We just need the intel arm image.

@huangjw806
Copy link
Contributor

We just need the intel arm image.

Okay, this release will include it.

@kwannoel kwannoel changed the title Build and publish RisingWave binaries for osx arm64, linux arm64, osx x86_64. Build and publish RisingWave binaries for linux arm64 Feb 2, 2024
@kwannoel
Copy link
Contributor Author

kwannoel commented Feb 5, 2024

Left with releasing the binary itself, that's blocked by:

  1. feat(cmd_all): support single_node mode #14951
  2. Tests for the binary
  3. Release testing for the binary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants