-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable conflict check for those row_id generated by rowIdGenerator #14796
Comments
Is it possible that _row_id is deleted from DML? |
Yes, So we need some way to let MaterializeExecutor if the row needs to be checked (comes from Update/delete DML) |
This only applies to the case where there is no downstream MV or index, right? With MV or index, we have to do the checks for inserts anyways. |
It can optimized for all tables without primary key, whether there are MVs downstream or not |
This issue has been open for 60 days with no activity. If you think it is still relevant today, and needs to be done in the near future, you can comment to update the status, or just manually remove the You can also confidently close this issue as not planned to keep our backlog clean. |
We have find the conflict check can be the bottleneck in #14635, even if we have optimized it with bloom filter and operator cach.
For the AppendOnly table without primary key, we do not need conflict check because all the row_id is generated by rowIdGenerator.
when the table is non-append only, we still need to check for for the delete and update DML statment. But the the op rows are most from insert or the table's upstream connector like kafka. So if we find a way to determine those rows whose row_id is generated by rowIdGenerator, we can save the conflict check.
The text was updated successfully, but these errors were encountered: