Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Rename ActorContext create #14749

Closed
chenzl25 opened this issue Jan 23, 2024 · 1 comment · Fixed by #14750
Closed

refactor: Rename ActorContext create #14749

chenzl25 opened this issue Jan 23, 2024 · 1 comment · Fixed by #14750
Milestone
release-1.7

Comments

@chenzl25
Copy link
Contributor 

          The name for this method seems to be outdated. Also, is `ActorContext::create` only supposed to be used by tests?

Originally posted by @BugenZhao in #14655 (comment)
@github-actions github-actions bot added this to the release-1.7 milestone Jan 23, 2024
@chenzl25
Copy link
Contributor Author

Maybe we can rename the create to for_test and rename the create_with_metrics to create in the future.

@chenzl25 chenzl25 mentioned this issue Jan 23, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
release-1.7
Development

Successfully merging a pull request may close this issue.

chore(stream): rename ActorContext creation methods risingwavelabs/risingwave
1 participant
@chenzl25