Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store WASM UDF in meta store #14568

Closed
fuyufjh opened this issue Jan 15, 2024 · 0 comments · Fixed by #15269
Closed

Store WASM UDF in meta store #14568

fuyufjh opened this issue Jan 15, 2024 · 0 comments · Fixed by #15269
Assignees
Milestone

Comments

@fuyufjh
Copy link
Member

fuyufjh commented Jan 15, 2024

You can embed WASM binaries into SQL using base64 encoding. RW will upload the binary into object store with the path defined in the parameter wasm_storage_url.

Why not just storing them in meta store? In most cases the WASM won't be very big and meta store (will be migrated to RDBMS e.g. PostgresQL) should be good enough. I prefer to make it simple and avoid introduce new dependent systems.

A related discussion: #12982. Also recommend meta store for it in my opinion.

The wasm binary in e2e test is about 1.5MB after strip, 400KB after compression. It sounds okay to store them into meta.

Let me note it down as an issue as a reminder.

Originally posted by @fuyufjh in #14271 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants