Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message by reporting the decoded datum #14456

Closed
fuyufjh opened this issue Jan 9, 2024 · 1 comment · Fixed by #14515
Closed

Improve error message by reporting the decoded datum #14456

fuyufjh opened this issue Jan 9, 2024 · 1 comment · Fixed by #14515
Assignees
Milestone

Comments

@fuyufjh
Copy link
Member

fuyufjh commented Jan 9, 2024

It's too painful to decode the memcomparable and value encoding manually 😇

panic!("pk {:?} should be in the cache", pk);

pk [....] should be in the cache

self.cached.try_insert(key, value).unwrap();

called Result::unwrap() on an Err value: BTree(OccupiedError…
@github-actions github-actions bot added this to the release-1.7 milestone Jan 9, 2024
@fuyufjh
Copy link
Member Author

fuyufjh commented Jan 9, 2024

By the way, Join key was not printed here. Please print join key as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants