Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actor_execution_time and actor_poll_duration both use total_poll_duration #14407

Open
lmatz opened this issue Jan 8, 2024 · 1 comment
Open
Assignees
Labels
no-issue-activity type/bug Something isn't working

Comments

@lmatz
Copy link
Contributor

lmatz commented Jan 8, 2024

Describe the bug

https://github.com/risingwavelabs/risingwave/blob/main/src/stream/src/task/stream_manager.rs#L719-L722

which value is it supposed to use? didn't find it

https://github.com/risingwavelabs/risingwave/blob/main/src/stream/src/task/stream_manager.rs#L739-L742

Additional context

I was looking for a metric that can show the processing time (avg, 99th, etc) of one row in each operator, is this actor_execution_time expected to record this? to detect all the bottlenecks of a stream query

(per row probably generates too much data points, sampling or per chunk is also good enough)

correct me if I am wrong, but the back pressure metric/graph shows only a portion of bottlenecks, doesn't it?
e.g. both upstream and downstream operators are slow and slow to the same extent

I think it could be a good first metric when investigating the scaling-up/out performance.

Is it also possible to show it on RW's dashboard together with the fragment graph

@lmatz lmatz added the type/bug Something isn't working label Jan 8, 2024
@github-actions github-actions bot added this to the release-1.7 milestone Jan 8, 2024
@lmatz lmatz modified the milestones: release-1.7, release-1.6 Jan 9, 2024
@fuyufjh fuyufjh modified the milestones: release-1.6, release-1.7 Jan 9, 2024
@lmatz lmatz removed this from the release-1.7 milestone Mar 6, 2024
Copy link
Contributor

This issue has been open for 60 days with no activity. Could you please update the status? Feel free to continue discussion or close as not planned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-issue-activity type/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants