Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

choose to detect inconsistency in materialized view executor #14309

Closed
lmatz opened this issue Jan 2, 2024 · 2 comments
Closed

choose to detect inconsistency in materialized view executor #14309

lmatz opened this issue Jan 2, 2024 · 2 comments

Comments

@lmatz
Copy link
Contributor

lmatz commented Jan 2, 2024

We intend to detect inconsistencies as upstream as possible.

sometimes, the inconsistency error may not originate from the table that produces such an error. The error may occur in the upstream MVs.

When it happens, we can turn this check on and let users recreate all the MVs once to see if we can catch the bug.

@github-actions github-actions bot added this to the release-1.6 milestone Jan 2, 2024
@BugenZhao
Copy link
Member

Do you mean enabling the "dry-run" of conflict handling for materialized views?

enum HandleConflictBehavior {
HANDLE_CONFLICT_BEHAVIOR_UNSPECIFIED = 0;
HANDLE_CONFLICT_BEHAVIOR_OVERWRITE = 1;
HANDLE_CONFLICT_BEHAVIOR_IGNORE = 2;
HANDLE_CONFLICT_BEHAVIOR_NO_CHECK = 3;
}

This sounds like a good point as it reuses the table state of Materialize to check the consistency without introducing new states. Some downsides:

  • The coverage of cases is limited. Since there are typically Join or Agg operations in every streaming job, we must also detect (and tolerate) any inconsistencies there first to make it possible for Materialize to find them.
  • Additional computation and I/O have to be paid on checking. It would be beneficial if we could configure it on the fly, as long as the computation is deterministic and reproducible.

@lmatz lmatz removed this from the release-1.6 milestone Jan 9, 2024
Copy link
Contributor

This issue has been open for 60 days with no activity. Could you please update the status? Feel free to continue discussion or close as not planned.

@lmatz lmatz closed this as not planned Won't fix, can't repro, duplicate, stale May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants