Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log internal table name also if any error with respect to a certain table id occurs #14275

Open
lmatz opened this issue Dec 29, 2023 · 1 comment
Assignees

Comments

@lmatz
Copy link
Contributor

lmatz commented Dec 29, 2023

For example, error like this:

mem-table operation inconsistent! table_id: 1190,

Suggested by @MrCroxx

Although we can find table ID to table name mapping on the Grafana,

for on-prem users, it would be more convenient if the user could post the log to us to investigate. It is also likely that he may not deploy the monitoring stack or the monitoring stack can go wrong due to unknown reasons.

@github-actions github-actions bot added this to the release-1.6 milestone Dec 29, 2023
@BugenZhao
Copy link
Member

The best approach is to always enter a tracing::Span that provides fields like table_id whenever we perform table operations. However, #12959 (comment) told us that frequent span construction will lead to performance problems.

I will try doing some exploration on this. Otherwise we may attach such context manually.

@lmatz lmatz modified the milestones: release-1.6, release-1.7 Jan 9, 2024
@fuyufjh fuyufjh self-assigned this Mar 6, 2024
@fuyufjh fuyufjh modified the milestones: release-1.7, release-1.8 Mar 6, 2024
@fuyufjh fuyufjh modified the milestones: release-1.9, release-1.10 May 13, 2024
@fuyufjh fuyufjh modified the milestones: release-1.10, release-1.11 Jul 10, 2024
@fuyufjh fuyufjh modified the milestones: release-2.0, release-2.1 Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants