Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improper metric usage batch_row_seq_scan_next_duration #14269

Closed
cloudcarver opened this issue Dec 29, 2023 · 3 comments
Closed

improper metric usage batch_row_seq_scan_next_duration #14269

cloudcarver opened this issue Dec 29, 2023 · 3 comments
Assignees
Milestone

Comments

@cloudcarver
Copy link
Contributor

Seems batch_row_seq_scan_next_duration stores query_id in the label. This means every query will produce a new time series, this is a bad practice when using metric.

IMHO, the better idea is to use log to record this information. In this case, we can check the exact query id in the log when we find a surge in the abnormal metric graph.

image

@github-actions github-actions bot added this to the release-1.6 milestone Dec 29, 2023
@fuyufjh
Copy link
Member

fuyufjh commented Jan 9, 2024

@liurenjie1024 Please take a look, thanks!

@liurenjie1024
Copy link
Contributor

It may cause high cardinality metrics in highly frequent distributed query, but our system assumes that no frequent distributed query happens, so I think it's ok to work. Metrics are disabled for high qps serving queries.

Copy link
Contributor

This issue has been open for 60 days with no activity. Could you please update the status? Feel free to continue discussion or close as not planned.

@liurenjie1024 liurenjie1024 closed this as not planned Won't fix, can't repro, duplicate, stale Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants