Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

require ES sink to specify upsert, and primary_key #14253

Open
xxchan opened this issue Dec 28, 2023 · 2 comments
Open

require ES sink to specify upsert, and primary_key #14253

xxchan opened this issue Dec 28, 2023 · 2 comments
Labels
no-issue-activity type/feature
Milestone
release-1.9

Comments

@xxchan
Copy link
Member

xxchan commented Dec 28, 2023

related discussion
@github-actions github-actions bot added this to the release-1.6 milestone Dec 28, 2023
@xxchan
Copy link
Member Author

xxchan commented Dec 28, 2023

Update: We should require primary_key, but there's another discussion that maybe we can deprecate type=upsert fully, because it can be implied from primary_key. There's also opinion that we'd better keep it, even it's not useful. https://risingwave-labs.slack.com/archives/C04F4RB1AHF/p1703752228928449?thread_ts=1703744966.610419&cid=C04F4RB1AHF

@xxchan xxchan modified the milestones: release-1.6, release-1.7 Jan 9, 2024
@xxchan xxchan modified the milestones: release-1.7, future-release-1.9 Mar 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue has been open for 60 days with no activity. Could you please update the status? Feel free to continue discussion or close as not planned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
no-issue-activity type/feature
Projects
None yet
Milestone
release-1.9
Development

No branches or pull requests
1 participant
@xxchan