Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not buffer all delete when always relax dyn filter right side changes #13998

Closed
st1page opened this issue Dec 14, 2023 · 1 comment
Closed

do not buffer all delete when always relax dyn filter right side changes #13998

st1page opened this issue Dec 14, 2023 · 1 comment
Milestone
release-1.6

Comments

@st1page
Copy link
Contributor

st1page commented Dec 14, 2023 •
edited
Loading

in #13985

risingwave/src/stream/src/executor/dynamic_filter.rs

Line 428 in 72b49a5

to_delete_rows.push(row.clone());

OOM risk

potential method

  • break the iter and flush the delete
  • support drain in state store?
@github-actions github-actions bot added this to the release-1.6 milestone Dec 14, 2023
@st1page st1page mentioned this issue Dec 14, 2023
Merged
9 tasks
@st1page st1page closed this as completed Dec 15, 2023
@st1page
Copy link
Contributor Author

st1page commented Dec 15, 2023

fixed by range delete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
release-1.6
Development

No branches or pull requests
1 participant
@st1page