Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: revisit the usage of hakari #13964

Closed
2 tasks
xxchan opened this issue Dec 13, 2023 · 1 comment
Closed
2 tasks

build: revisit the usage of hakari #13964

xxchan opened this issue Dec 13, 2023 · 1 comment
Assignees
Milestone

Comments

@xxchan
Copy link
Member

xxchan commented Dec 13, 2023

  • It doesn't seem to unify enough features. e.g., cargo build -p risingwave_cmd_all , and then cargo build -p risingwave_connector will rebuild from log, which is a lot to re-compile.
  • Checks whether hakari unifies dev-dependencies. It caused a problem here (heavy dev-only dependency is unified, and caused increased compilation time): feat(sink): support deltalake sink with rust sdk #13600 (comment)
    • @hzxa21 mentioned that if that is the case, there can be severe problem because some features enabled in dev-dependencies can affect the code behavior in release build. For example, the epoch can be totally wrong in release build. (feature enable_test_epoch).
@xxchan xxchan self-assigned this Dec 13, 2023
@github-actions github-actions bot added this to the release-1.6 milestone Dec 13, 2023
@xxchan xxchan modified the milestones: release-1.6, release-1.7 Jan 9, 2024
@xxchan xxchan modified the milestones: release-1.7, future-release-1.9 Mar 6, 2024
@xxchan
Copy link
Member Author

xxchan commented May 2, 2024

#16142

@xxchan xxchan closed this as not planned Won't fix, can't repro, duplicate, stale May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant