Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discussion: avoid periodical logs #13953

Closed
xxchan opened this issue Dec 12, 2023 · 1 comment
Closed

Discussion: avoid periodical logs #13953

xxchan opened this issue Dec 12, 2023 · 1 comment

Comments

@xxchan
Copy link
Member

xxchan commented Dec 12, 2023 

          > BTW that line is unpin snapshot with RPC. It's normal for an idle cluster to only have this log.

From my perspective, in production we should never include logs that are triggered automatically and periodically, unless they're user-facing. Also applies to the DEBUG logs in hummock event handler.

Originally posted by @BugenZhao in #12610 (comment)

These seems verbose even for developers.

image
@github-actions github-actions bot added this to the release-1.6 milestone Dec 12, 2023
@fuyufjh
Copy link
Member

fuyufjh commented Dec 13, 2023

+1. Previously I opened such an issue but nobody cares 🥹

#7872

xxchan added a commit that referenced this issue Jan 9, 2024
@xxchan
chore: remove some periodical logs
d206cf7 
#13953
@xxchan xxchan mentioned this issue Jan 9, 2024
Merged
9 tasks
@xxchan xxchan removed this from the release-1.6 milestone Jan 9, 2024
@fuyufjh fuyufjh closed this as completed Feb 27, 2024
xxchan added a commit that referenced this issue Aug 18, 2024
@xxchan
refactor: reduce periodical logs
52ef6c0 
related #13953

Signed-off-by: xxchan <[email protected]>
@xxchan xxchan mentioned this issue Aug 18, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fuyufjh @xxchan