Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potentially pinning an epoch for long time in long transaction #13885

Closed
wenym1 opened this issue Dec 8, 2023 · 1 comment
Closed

Potentially pinning an epoch for long time in long transaction #13885

wenym1 opened this issue Dec 8, 2023 · 1 comment
Assignees
Labels
type/bug Something isn't working
Milestone

Comments

@wenym1
Copy link
Contributor

wenym1 commented Dec 8, 2023

Describe the bug

Currently in our batch query, for a single query, we will unpin the epoch very soon when all iterators of hummock have been created. However, in a long transaction, after we start the transaction, we will not unpin the epoch before the user manually stop the transaction, which may cause the epoch to be pinned for a long time. Pinning an epoch for long time will make the safe epoch of hummock lags behind the max committed epoch for a long time, and the data size will be large because we need to preserve the multiple versions of a key in our sst.

Therefore we need some mechanism to handle this corner case in case that a accidentally started transaction affect our the performance of our system.

Error message/log

No response

To Reproduce

No response

Expected behavior

No response

How did you deploy RisingWave?

No response

The version of RisingWave

No response

Additional context

No response

@wenym1 wenym1 added the type/bug Something isn't working label Dec 8, 2023
@github-actions github-actions bot added this to the release-1.6 milestone Dec 8, 2023
@wenym1 wenym1 modified the milestones: release-1.6, release-1.7 Jan 9, 2024
@fuyufjh fuyufjh modified the milestones: release-1.6, release-1.7 Jan 9, 2024
@wenym1
Copy link
Contributor Author

wenym1 commented Jan 17, 2024

Resolved by #14566

@wenym1 wenym1 closed this as completed Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants