Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor generic::scan to get rid of TableDesc #13874

Closed
kwannoel opened this issue Dec 8, 2023 · 1 comment
Closed

Refactor generic::scan to get rid of TableDesc #13874

kwannoel opened this issue Dec 8, 2023 · 1 comment
Labels
type/feature
Milestone
release-1.6

Comments

@kwannoel
Copy link
Contributor

kwannoel commented Dec 8, 2023

TableCatalog is used by generic::scan now.

Refactor is not done in #13622 to avoid a large amount of changes.

After that PR is merged, we should do the refactor.
@github-actions github-actions bot added this to the release-1.6 milestone Dec 8, 2023
@kwannoel kwannoel mentioned this issue Dec 8, 2023
Merged
10 tasks
@kwannoel
Copy link
Contributor Author

kwannoel commented Jan 9, 2024 •
edited
Loading

As @st1page mentioned offline, TableDesc is used as the physical table descriptor. So we don't actually want to remove this abstraction.

@kwannoel kwannoel closed this as not planned Won't fix, can't repro, duplicate, stale Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/feature
Projects
None yet
Milestone
release-1.6
Development

No branches or pull requests
1 participant
@kwannoel