Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not block barrier when rate limiting with smaller than chunk_size #13799

Closed
2 of 7 tasks
kwannoel opened this issue Dec 5, 2023 · 3 comments · Fixed by #13800
Closed
2 of 7 tasks

Do not block barrier when rate limiting with smaller than chunk_size #13799

kwannoel opened this issue Dec 5, 2023 · 3 comments · Fixed by #13800
Assignees

Comments

@kwannoel
Copy link
Contributor

kwannoel commented Dec 5, 2023

@github-actions github-actions bot added this to the release-1.6 milestone Dec 5, 2023
@kwannoel kwannoel self-assigned this Dec 5, 2023
@BugenZhao
Copy link
Member

What's the plan for not blocking the barrier? I guess for those "source-like" executors such as Source or DML, it's natural. For other executors, we have to do "barrier stealing/rearrangement" and the consistency could be broken.

@kwannoel
Copy link
Contributor Author

kwannoel commented Dec 5, 2023

What's the plan for not blocking the barrier? I guess for those "source-like" executors such as Source or DML, it's natural. For other executors, we have to do "barrier stealing/rearrangement" and the consistency could be broken.

Yeah actually it's just for Source / DML.

The plan is to just throttle stream reader. I have a WIP PR where I will add more details soon.

@kwannoel kwannoel changed the title Do not block barrier when rate limiting Do not block barrier when rate limiting with smaller than chunk_size Jan 9, 2024
@kwannoel kwannoel removed this from the release-1.6 milestone Jan 9, 2024
@kwannoel
Copy link
Contributor Author

Source is pending #14215 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants