Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(meta): better handle two compactor register with the same name. #13754

Open
KeXiangWang opened this issue Nov 30, 2023 · 1 comment
Open

Comments

@KeXiangWang
Copy link
Contributor

Is your feature request related to a problem? Please describe.

One user use a service discovery to expose the container to each others. So when filling the argument advertise-addr of compactor, he uses a service discovery address. But When a component communicate with Meta through MetaClient, MetaClient identifies the component based on its advertise-addr . As a result, both of two compactors use the same advertise-addr . When a new compactor joins, Meta wrongly sends an Info::Snapshot notification to the running compactor, causing the running compactor panic.

Describe the solution you'd like

Better handle this situation.

  1. Double check with other component.
  2. If this happen, report some error instead of panic.
  3. Add more documents to guide user to fill advertise-addr.

Describe alternatives you've considered

No response

Additional context

To reproduce:

Run docker compose up -d on https://github.com/risingwavelabs/risingwave/tree/wkx/print-notification.

@KeXiangWang KeXiangWang self-assigned this Nov 30, 2023
@github-actions github-actions bot added this to the release-1.5 milestone Nov 30, 2023
@fuyufjh fuyufjh modified the milestones: release-1.5, release-1.6 Dec 4, 2023
@KeXiangWang KeXiangWang modified the milestones: release-1.6, release-1.7 Jan 10, 2024
@KeXiangWang KeXiangWang modified the milestones: release-1.7, release-1.9 Apr 8, 2024
@KeXiangWang KeXiangWang modified the milestones: release-1.9, release-1.10 May 14, 2024
Copy link
Contributor

github-actions bot commented Aug 1, 2024

This issue has been open for 60 days with no activity.

If you think it is still relevant today, and needs to be done in the near future, you can comment to update the status, or just manually remove the no-issue-activity label.

You can also confidently close this issue as not planned to keep our backlog clean.
Don't worry if you think the issue is still valuable to continue in the future.
It's searchable and can be reopened when it's time. 😄

@KeXiangWang KeXiangWang removed this from the release-1.10 milestone Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants