Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ExprVisitable for plan nodes #13510

Closed
chenzl25 opened this issue Nov 20, 2023 · 0 comments · Fixed by #13587
Closed

feat: support ExprVisitable for plan nodes #13510

chenzl25 opened this issue Nov 20, 2023 · 0 comments · Fixed by #13587

Comments

@chenzl25
Copy link
Contributor

chenzl25 commented Nov 20, 2023

Is your feature request related to a problem? Please describe.

I already have implemented ExprRewritable for each plan node, while it lacks a corresponding ExprVisitable to visit plan nodes instead of rewriting them. #13459 has found that ExprRewritable is related costly. If we can visit the plan node to check whether we actually need to rewrite exprs we can save CPU cost.

pub trait ExprVisitable {
    fn visit_exprs(&self, _r: &mut dyn ExprVisitor<Result = ()>) {
        unimplemented!()
    }
}

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant