Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add another docker layer upon the basic rw image with debug tools #13471

Open
lmatz opened this issue Nov 16, 2023 · 4 comments
Open

add another docker layer upon the basic rw image with debug tools #13471

lmatz opened this issue Nov 16, 2023 · 4 comments

Comments

@lmatz
Copy link
Contributor

lmatz commented Nov 16, 2023

when trying to generate a CPU flame graph in a RW cluster, @MrCroxx suggested that

maybe we can add another docker layer upon the basic rw image with debug tools?

try to gather what debug tools are needed except the toolchain for CPU flame graph, please leave a message

we can create another build image pipeline on Buildkite later

@github-actions github-actions bot added this to the release-1.5 milestone Nov 16, 2023
@BugenZhao
Copy link
Member

BugenZhao commented Nov 16, 2023

I had an attempt before: #12588, including GDB, LLDB, and debugging symbols.

I'm happy if someone would continue working on that.

@fuyufjh fuyufjh removed this from the release-1.5 milestone Dec 6, 2023
@BugenZhao
Copy link
Member

I had an attempt before: #12588, including GDB, LLDB, and debugging symbols.

The motivation is somehow different: I was focusing on offline debugging there. For example, download the core dump from the production container, then import it into the corresponding debug image. Users will continue to deploy using the original image.

Here we mentioned "flame graph", so it's actually online debugging. It appears that we have to include those debug tools in the production image itself.

@lmatz
Copy link
Contributor Author

lmatz commented Jan 11, 2024

#14432 related but for debugging external systems instead of risingwave itself, just leave a record here

Copy link
Contributor

This issue has been open for 60 days with no activity. Could you please update the status? Feel free to continue discussion or close as not planned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants