Potential misuse of timestamp (without time zone)

[xiangjinwu]

timestamptz represents an absolute point in time, while timestamp represents a watch reading including a date and time depending on local law with unpredictable changes.

risingwave/src/frontend/src/catalog/system_catalog/rw_catalog/rw_meta_snapshot.rs

Lines 44 to 55 in 4e16834

	let try_get_date_time = |epoch: u64| {
	if epoch == 0 {
	return None;
	}
	let time_millis = Epoch::from(epoch).as_unix_millis();
	Timestamp::with_secs_nsecs(
	(time_millis / 1000) as i64,
	(time_millis % 1000 * 1_000_000) as u32,
	)
	.map(ScalarImpl::Timestamp)
	.ok()
	};

risingwave/src/frontend/src/optimizer/plan_node/logical_source.rs

Lines 181 to 186 in 4e16834

	&Field {
	name: "last_edit_time".to_string(),
	data_type: DataType::Timestamp,
	sub_fields: vec![],
	type_name: "".to_string(),
	},

risingwave/src/stream/src/executor/source/list_executor.rs

Lines 101 to 117 in 4e16834

	let rows = page
	.into_iter()
	.map(|split| {
	(
	Op::Insert,
	OwnedRow::new(vec![
	Some(ScalarImpl::Utf8(split.name.into_boxed_str())),
	Some(ScalarImpl::Timestamp(split.timestamp)),
	Some(ScalarImpl::Int64(split.size)),
	]),
	)
	})
	.collect::<Vec<_>>();
	StreamChunk::from_rows(
	&rows,
	&[DataType::Varchar, DataType::Timestamp, DataType::Int64],
	)

[xiangjinwu]

About usage in s3 source: #13414 (comment)