Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve watermark error and show watermark columns in explain #13355

Closed
fuyufjh opened this issue Nov 10, 2023 · 1 comment
Closed

Improve watermark error and show watermark columns in explain #13355

fuyufjh opened this issue Nov 10, 2023 · 1 comment
Assignees
Milestone

Comments

@fuyufjh
Copy link
Member

fuyufjh commented Nov 10, 2023

Is your feature request related to a problem? Please describe.

...be executed in Emit-On-Window-Close mode.
HINT: Please make sure there is one and only one watermark column in GROUP BY

This error is unfriendly to users because they don't know the derivation rule of watermark.

I am considering to show the watermark columns in explain, and guide the users to check their queries in the above error message.

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response

@github-actions github-actions bot added this to the release-1.5 milestone Nov 10, 2023
@fuyufjh fuyufjh modified the milestones: release-1.5, release-1.6 Dec 4, 2023
@fuyufjh fuyufjh self-assigned this Dec 4, 2023
@fuyufjh fuyufjh modified the milestones: release-1.6, release-1.7 Jan 9, 2024
@stdrc stdrc self-assigned this Jan 9, 2024
@fuyufjh fuyufjh removed their assignment Jan 9, 2024
@stdrc stdrc modified the milestones: release-1.7, release-1.8 Mar 6, 2024
@stdrc stdrc modified the milestones: release-1.8, release-1.9 Apr 8, 2024
@stdrc stdrc modified the milestones: release-1.9, release-1.10 May 10, 2024
@stdrc stdrc modified the milestones: release-1.10, release-1.11 Jul 10, 2024
@stdrc stdrc modified the milestones: release-2.0, release-2.1 Aug 22, 2024
@stdrc stdrc modified the milestones: release-2.1, release-2.2 Oct 17, 2024
@stdrc
Copy link
Member

stdrc commented Jan 13, 2025

We now have output_watermarks field in each plan node in explain, and after #19894 and #19998, this kind of error message won't happen as often as before.

@stdrc stdrc closed this as completed Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants