You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, we utilize the FrontendEnv extensively in the risingwave-frontend crate, which complicates and makes testing the binder a tedious task. Creating a FrontendEnv relies on the tokio runtime, requiring all binder tests to initialize a tokio runtime. For example:
Currently, we utilize the
FrontendEnv
extensively in therisingwave-frontend
crate, which complicates and makes testing the binder a tedious task. Creating aFrontendEnv
relies on thetokio
runtime, requiring all binder tests to initialize a tokio runtime. For example:Removing
tokio::test
seems strange, but if we do so, the test will panic.To create
FrontendEnv
, we need to initialize ahummock_snapshot_manager
and spawn an unpinned background worker.risingwave/src/frontend/src/scheduler/snapshot.rs
Line 149 in 887655f
The field is definitely useless in the whole binder module, I'd prefer split a
BinderEnv
fromFrontendEnv
.The text was updated successfully, but these errors were encountered: