Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(frontend): implement real expr col_description, obj_description, shobj_description #13213

Open
yezizp2012 opened this issue Nov 2, 2023 · 2 comments
Open

feat(frontend): implement real expr col_description, obj_description, shobj_description #13213

yezizp2012 opened this issue Nov 2, 2023 · 2 comments
Labels
help wanted Issues that need help from contributors no-issue-activity type/feature

Comments

@yezizp2012
Copy link
Member

yezizp2012 commented Nov 2, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.

Since #12663 is done, we can implement it using capturing context or rewrite them as query on rw_description.

// TODO: really implement them.
// https://www.postgresql.org/docs/9.5/functions-info.html#FUNCTIONS-INFO-COMMENT-TABLE
// WARN: Hacked in [`Binder::bind_function`]!!!
("col_description", raw_call(ExprType::ColDescription)),
("obj_description", raw_literal(ExprImpl::literal_varchar("".to_string()))),
("shobj_description", raw_literal(ExprImpl::literal_varchar("".to_string()))),

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response
@github-actions github-actions bot added this to the release-1.5 milestone Nov 2, 2023
@yezizp2012 yezizp2012 changed the title feat: implement real expr col_description, obj_description, shobj_description feat(frontend): implement real expr col_description, obj_description, shobj_description Nov 2, 2023
@TennyZhuang
Copy link
Contributor

TennyZhuang commented Nov 9, 2023 •
edited
Loading

Please note that I've introduced a hack in #11407 . I guess it can be removed now.

@yezizp2012 yezizp2012 added the help wanted Issues that need help from contributors label Dec 4, 2023
@yezizp2012 yezizp2012 removed this from the release-1.5 milestone Dec 4, 2023
@github-actions GitHub Actions
Copy link
Contributor

This issue has been open for 60 days with no activity. Could you please update the status? Feel free to continue discussion or close as not planned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Issues that need help from contributors no-issue-activity type/feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TennyZhuang @yezizp2012