Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist the backfill state to record backfill progress #13204

Closed
Tracked by #11079
StrikeW opened this issue Nov 2, 2023 · 3 comments · Fixed by #13276
Closed
Tracked by #11079

Persist the backfill state to record backfill progress #13204

StrikeW opened this issue Nov 2, 2023 · 3 comments · Fixed by #13276
Assignees
Milestone

Comments

@StrikeW
Copy link
Contributor

StrikeW commented Nov 2, 2023

#12535 doesn’t persist the backfill state yet, it will backfill again during recovery.

@kwannoel
Copy link
Contributor

kwannoel commented Nov 7, 2023

Do we also want to handle recovery for this issue? Seems like this PR only persist the backfill state for cdc executor, but I'm not sure if that's sufficient.

In meta, we need to persist the table fragments and table proto as well. Otherwise they will be lost on recovery.

Similar to #12167

@StrikeW
Copy link
Contributor Author

StrikeW commented Nov 9, 2023

I take a look of #12167, since CREATE TABLE is always Foreground (it will return success after collect the initial barrier), so I think we don't need to recover its progress likes Background streaming job does.

@kwannoel
Copy link
Contributor

kwannoel commented Nov 9, 2023

I take a look of #12167, since CREATE TABLE is always Foreground (it will return success after collect the initial barrier), so I think we don't need to recover its progress likes Background streaming job does.

Ah got it. Makes sense to me.

@StrikeW StrikeW changed the title Persist the backfill state when the backfill task is finished Persist the backfill state to record backfill progress Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants