-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimizer: introduce 2 new operators for scanning sys table / CDC table #13146
Comments
+1. Arrangement backfill now requires full I think we should refactor it before adding full |
Additionally, they should have their own respective proto definitions as well, rather than rely on the same |
after checking the current implementation, LGTM. because we do not have many common logic such as predicate push down and column pruning on the CDC table's backfill and stream scan... |
This issue has been open for 60 days with no activity. Could you please update the status? Feel free to continue discussion or close as not planned. |
From #13146 (comment)
It does not seem there's much in common, both between |
Recommend to introduce a new physical operator
CdcTableScan
, because scanning from RW table, sys table or CDC table are completely different in terms of implementation.Here the
if self.predicate().always_true()
actaully implies a huge difference in implementation, which should be reflected by different phyiscal operators, instead of suchif-else
branch.I guess this might be introduced by
sys table
before, so it's acceptable for me too keep it as is now and do refactor later.Originally posted by @fuyufjh in #12535 (comment)
The text was updated successfully, but these errors were encountered: