Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimizer: bool expression folding "self equal" as always true #12931

Closed
st1page opened this issue Oct 18, 2023 · 1 comment · Fixed by #15901
Closed

optimizer: bool expression folding "self equal" as always true #12931

st1page opened this issue Oct 18, 2023 · 1 comment · Fixed by #15901
Assignees
Labels
type/bug Something isn't working
Milestone

Comments

@st1page
Copy link
Contributor

st1page commented Oct 18, 2023

│ │ └─StreamFilter { predicate: (order_line.ol_d_id = order_line.ol_d_id) }
│ │ └─StreamTableScan { table: order_line, columns: [order_line.ol_o_id, order_line.ol_d_id, order_line.ol_w_id, order_line.ol_i_id, order_line.ol_amount, order_line.ol_number], pk: [order_line.ol_w_id, order_line.ol_d_id, order_line.ol_o_id, order_line.ol_number], dist: UpstreamHashShard(order_line.ol_o_id, order_line.ol_d_id, order_line.ol_w_id, order_line.ol_number) }

@github-actions github-actions bot added this to the release-1.4 milestone Oct 18, 2023
@fuyufjh fuyufjh added the type/bug Something isn't working label Nov 8, 2023
@fuyufjh fuyufjh modified the milestones: release-1.4, release-1.5 Nov 8, 2023
@st1page st1page modified the milestones: release-1.5, release-1.6 Dec 5, 2023
@st1page st1page modified the milestones: release-1.6, release-1.7 Jan 9, 2024
@xzhseh xzhseh self-assigned this Feb 29, 2024
@xzhseh xzhseh modified the milestones: release-1.7, release-1.8 Mar 6, 2024
@xzhseh
Copy link
Contributor

xzhseh commented Mar 13, 2024

It's worth noticing that this does not only happen to StreamFilter, but also the predicates of StreamHashJoin and BatchHashJoin.

└─LogicalJoin { type: LeftAnti, on: (order_line.ol_o_id = order_line.ol_o_id) AND (order_line.ol_w_id = order_line.ol_w_id) AND (order_line.ol_d_id = order_line.ol_d_id) AND (order_line.ol_delivery_d > order_line.ol_delivery_d), output: [supplier.s_name] }

└─BatchHashJoin { type: LeftAnti, predicate: order_line.ol_o_id = order_line.ol_o_id AND order_line.ol_w_id = order_line.ol_w_id AND order_line.ol_d_id = order_line.ol_d_id AND (order_line.ol_delivery_d > order_line.ol_delivery_d), output: [supplier.s_name] }

└─StreamHashJoin { type: LeftAnti, predicate: order_line.ol_o_id = order_line.ol_o_id AND order_line.ol_w_id = order_line.ol_w_id AND order_line.ol_d_id = order_line.ol_d_id AND (order_line.ol_delivery_d > order_line.ol_delivery_d), output: [supplier.s_name, stock.s_w_id, stock.s_i_id, order_line.ol_d_id, order_line.ol_o_id, order_line.ol_number, supplier.s_nationkey, $expr1, order_line.ol_w_id] }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants