Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(optimizer): split stream key and unique key #12514

Closed
st1page opened this issue Sep 25, 2023 · 2 comments
Closed

refactor(optimizer): split stream key and unique key #12514

st1page opened this issue Sep 25, 2023 · 2 comments
Assignees
Milestone

Comments

@st1page
Copy link
Contributor

st1page commented Sep 25, 2023

Currently, we have the pub fn logical_pk() method on plan Node.
But now we find stream_key is a very special concept, so we need to clarify here.
finally, we will have two different method

pub fn stream_key(&self) -> Option<&[usize]>;
pub fn unqiue_key(&self) -> Vec<Vec<usize>>;
@st1page st1page self-assigned this Sep 25, 2023
@github-actions github-actions bot added this to the release-1.3 milestone Sep 25, 2023
@BugenZhao
Copy link
Member

Related #9375

@st1page st1page modified the milestones: release-1.3, release-1.4 Oct 10, 2023
@st1page st1page modified the milestones: release-1.4, release-1.5 Nov 8, 2023
@st1page st1page modified the milestones: release-1.5, release-1.6 Dec 5, 2023
@st1page st1page modified the milestones: release-1.6, release-1.7 Jan 9, 2024
@st1page st1page modified the milestones: release-1.7, release-1.8 Mar 6, 2024
@st1page st1page modified the milestones: release-1.9, release-1.10 May 14, 2024
Copy link
Contributor

github-actions bot commented Aug 1, 2024

This issue has been open for 60 days with no activity.

If you think it is still relevant today, and needs to be done in the near future, you can comment to update the status, or just manually remove the no-issue-activity label.

You can also confidently close this issue as not planned to keep our backlog clean.
Don't worry if you think the issue is still valuable to continue in the future.
It's searchable and can be reopened when it's time. 😄

@st1page st1page closed this as not planned Won't fix, can't repro, duplicate, stale Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants