Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support reverse scan for hummock #12367

Closed
Little-Wallace opened this issue Sep 18, 2023 · 6 comments
Closed

feat: support reverse scan for hummock #12367

Little-Wallace opened this issue Sep 18, 2023 · 6 comments
Assignees
Milestone

Comments

@Little-Wallace
Copy link
Contributor

Is your feature request related to a problem? Please describe.

In past scenes, we only need forward scan in all of state executor. So we remove backward scan of hummock because it is hard to implement reverse iterator of delete-range.

@st1page propose a expanded range cache to store part of keys in memory. Sometimes we may need to load more data from hummock, and if we want to load data from the left side of cache, we need to a reverse-scan.

Describe the solution you'd like

The interface shall support range bound and item limit.

Describe alternatives you've considered

Maybe I need some time to think of how to implement reverse iterator of delete range.

Additional context

No response

@github-actions github-actions bot added this to the release-1.3 milestone Sep 18, 2023
@st1page
Copy link
Contributor

st1page commented Sep 18, 2023

c.c. @stdrc

@fuyufjh fuyufjh modified the milestones: release-1.3, release-1.4 Oct 10, 2023
@fuyufjh
Copy link
Member

fuyufjh commented Oct 10, 2023

#12570

@hzxa21
Copy link
Collaborator

hzxa21 commented Nov 8, 2023

This can be simplified with #13148

@hzxa21 hzxa21 modified the milestones: release-1.4, release-1.5 Nov 8, 2023
@TennyZhuang TennyZhuang modified the milestones: release-1.5, release-1.6 Dec 11, 2023
@hzxa21
Copy link
Collaborator

hzxa21 commented Jan 9, 2024

#13148 is done. I think we can continue to support reverse scan based on vnode watermark. @Little-Wallace @wenym1

@hzxa21 hzxa21 modified the milestones: release-1.6, release-1.7 Jan 9, 2024
@fuyufjh
Copy link
Member

fuyufjh commented Jan 12, 2024

Ping. Over-window function is still waiting for this.

@hzxa21
Copy link
Collaborator

hzxa21 commented May 28, 2024

Done in #12570

@hzxa21 hzxa21 closed this as completed May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants