Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: define generated column on table/source whose schema is externally defined #12209

Closed
st1page opened this issue Sep 11, 2023 · 2 comments · Fixed by #14644
Closed

feat: define generated column on table/source whose schema is externally defined #12209

st1page opened this issue Sep 11, 2023 · 2 comments · Fixed by #14644
Assignees
Milestone

Comments

@st1page
Copy link
Contributor

st1page commented Sep 11, 2023

Currently, we do not allow user to define schema in column clause

CREATE SOURCE(a int, b int) FORMAT PLAIN ENCODE PROTOBUF;
 ERROR: ExecuteError: Protocol error: User-defined schema is not allowed with FORMAT PLAIN ENCODE PROTOBUF

When the user wants to define a generated column, he must specify columns in the create source/table statement. We might need to introduce another syntax.

CREATE SOURCE(*, proc_time timestampz AS proctime()) FORMAT PLAIN ENCODE PROTOBUF;
@yuhao-su
Copy link
Contributor

Should we allow writing filed names apart from * ?

Should we allow * written in other parts other than the very beginning?

@st1page st1page modified the milestones: release-1.3, release-1.4 Oct 10, 2023
@st1page
Copy link
Contributor Author

st1page commented Oct 10, 2023

Should we allow writing filed names apart from * ?

Should we allow * written in other parts other than the very beginning?

I think we can disallow them currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants