-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: specifying table schema when creating source/table from avro/protobuf encode whose full schema is externally defined #12199
Comments
It feels like this is not necessary. They may just ignore these columns when creating MVs on this source.
+1 for the syntax of your proposed. |
But when they create tables with primary key, the specified columns influence which columns will be materialized in storage. |
One thing semi-related to this issue is #10949. If user can specify a subset of columns, we may be able to filter out unnecessary changes (new row == old row) in the Table's materialize executor during the conflict check. |
The feature seems not a pain point. But still have some concerns about the compatibility when updating schema. |
we can allow user-defined parts only when both name and type are matched with the ones mapped from avro/pb. Let's take another look, cc @st1page |
This issue has been open for 60 days with no activity. Could you please update the status? Feel free to continue discussion or close as not planned. |
Currently, we do not allow user to define schema in column clause
But some user needs it to prune columns, especially when they are creating a table with the connector, the selected columns determine how many columns will be materialized in storage. Also, casting the source data into the expected datatype is needed too.
Another issue is that if the user want to define a generated column, he must specify columns in the create source/table statement. We might need to introduce another syntax #12209fixedThe text was updated successfully, but these errors were encountered: