Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/docker: use cargo chef to prepare dependencies. #11378

Closed
xxchan opened this issue Aug 1, 2023 · 4 comments
Closed

ci/docker: use cargo chef to prepare dependencies. #11378

xxchan opened this issue Aug 1, 2023 · 4 comments

Comments

@xxchan
Copy link
Member

xxchan commented Aug 1, 2023

https://github.com/LukeMathWalker/cargo-chef

It can speed up docker build by building all dependencies in one layer, and then we can reuse it as docker image cache.

@github-actions github-actions bot added this to the release-1.2 milestone Aug 1, 2023
@xxchan
Copy link
Member Author

xxchan commented Aug 1, 2023

For docker build, I think alternatively we can also use sccache for it (with a different S3 prefix).

But maybe we can also use cargo chef (and maybe sunset sccache) in CI to achieve #11097 #9852 (comment)

@xxchan
Copy link
Member Author

xxchan commented Aug 1, 2023

For java, it seems we can simply use pom.xml https://stackoverflow.com/questions/42208442/maven-docker-cache-dependencies

A writeup about rust's problem, and many solutions https://hackmd.io/@kobzol/S17NS71bh#Better-support-of-Docker-layer-caching-in-Cargo

@BugenZhao
Copy link
Member

Seems worthwhile as our folks now often build docker images manually for the purpose of benchmarking, and speeding up the build process could result in a smoother experience and significant cost savings. 🤔

@xxchan xxchan changed the title ci: use cargo chef to prepare dependencies. ci/docker: use cargo chef to prepare dependencies. Aug 10, 2023
@fuyufjh fuyufjh removed this from the release-1.2 milestone Sep 11, 2023
Copy link
Contributor

This issue has been open for 60 days with no activity. Could you please update the status? Feel free to continue discussion or close as not planned.

@xxchan xxchan closed this as not planned Won't fix, can't repro, duplicate, stale Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants