From c22c4265052c2a4f2876132a10a0b522ec7c03c9 Mon Sep 17 00:00:00 2001
From: "Zhanxiang (Patrick) Huang" <hzxa21@hotmail.com>
Date: Thu, 4 Jul 2024 10:45:42 +0800
Subject: [PATCH] feat(telemetry): add object store media type in mete
 telemetry report (#17553)

---
 proto/telemetry.proto               |  3 +++
 src/meta/node/src/server.rs         |  2 ++
 src/meta/src/hummock/manager/mod.rs |  4 ++++
 src/meta/src/telemetry.rs           | 12 +++++++++++-
 src/object_store/src/object/mod.rs  |  4 ++++
 5 files changed, 24 insertions(+), 1 deletion(-)

diff --git a/proto/telemetry.proto b/proto/telemetry.proto
index a362284a2fde6..a3c4ab7ef9dfa 100644
--- a/proto/telemetry.proto
+++ b/proto/telemetry.proto
@@ -99,6 +99,9 @@ message MetaReport {
 
   // How the cluster is deployed
   TelemetryClusterType cluster_type = 7;
+
+  // The object store media type obtained from ObjectStore::store_media_type
+  string object_store_media_type = 8;
 }
 
 enum PlanOptimization {
diff --git a/src/meta/node/src/server.rs b/src/meta/node/src/server.rs
index 43b6342e22ed5..57ccad6c9b5e6 100644
--- a/src/meta/node/src/server.rs
+++ b/src/meta/node/src/server.rs
@@ -478,6 +478,7 @@ pub async fn start_service_as_election_leader(
     )
     .await
     .unwrap();
+    let object_store_media_type = hummock_manager.object_store_media_type();
 
     let meta_member_srv = MetaMemberServiceImpl::new(match election_client.clone() {
         None => Either::Right(address_info.clone()),
@@ -742,6 +743,7 @@ pub async fn start_service_as_election_leader(
         Arc::new(MetaReportCreator::new(
             metadata_manager.clone(),
             env.meta_store().backend(),
+            object_store_media_type,
         )),
     );
 
diff --git a/src/meta/src/hummock/manager/mod.rs b/src/meta/src/hummock/manager/mod.rs
index e3511d1e4b204..65eede718c5c4 100644
--- a/src/meta/src/hummock/manager/mod.rs
+++ b/src/meta/src/hummock/manager/mod.rs
@@ -558,6 +558,10 @@ impl HummockManager {
     pub fn metadata_manager(&self) -> &MetadataManager {
         &self.metadata_manager
     }
+
+    pub fn object_store_media_type(&self) -> &'static str {
+        self.object_store.media_type()
+    }
 }
 
 async fn write_exclusive_cluster_id(
diff --git a/src/meta/src/telemetry.rs b/src/meta/src/telemetry.rs
index aa623c711dbec..27456289aa3d3 100644
--- a/src/meta/src/telemetry.rs
+++ b/src/meta/src/telemetry.rs
@@ -71,6 +71,7 @@ pub struct MetaTelemetryReport {
 
     // Get the ENV from key `TELEMETRY_CLUSTER_TYPE`
     cluster_type: PbTelemetryClusterType,
+    object_store_media_type: &'static str,
 }
 
 impl From<MetaTelemetryJobDesc> for risingwave_pb::telemetry::StreamJobDesc {
@@ -117,6 +118,7 @@ impl TelemetryToProtobuf for MetaTelemetryReport {
             stream_job_count: self.streaming_job_count as u32,
             stream_jobs: self.job_desc.into_iter().map(|job| job.into()).collect(),
             cluster_type: self.cluster_type as i32,
+            object_store_media_type: self.object_store_media_type.to_string(),
         };
         pb_report.encode_to_vec()
     }
@@ -143,13 +145,19 @@ impl TelemetryInfoFetcher for MetaTelemetryInfoFetcher {
 pub struct MetaReportCreator {
     metadata_manager: MetadataManager,
     meta_backend: MetaBackend,
+    object_store_media_type: &'static str,
 }
 
 impl MetaReportCreator {
-    pub fn new(metadata_manager: MetadataManager, meta_backend: MetaBackend) -> Self {
+    pub fn new(
+        metadata_manager: MetadataManager,
+        meta_backend: MetaBackend,
+        object_store_media_type: &'static str,
+    ) -> Self {
         Self {
             metadata_manager,
             meta_backend,
+            object_store_media_type,
         }
     }
 }
@@ -204,6 +212,7 @@ impl TelemetryReportCreator for MetaReportCreator {
             meta_backend: self.meta_backend,
             job_desc: stream_job_desc,
             cluster_type: telemetry_cluster_type_from_env_var(),
+            object_store_media_type: self.object_store_media_type,
         })
     }
 
@@ -255,6 +264,7 @@ mod test {
             },
             job_desc: vec![],
             cluster_type: PbTelemetryClusterType::Unspecified,
+            object_store_media_type: "s3",
         };
 
         let pb_bytes = report.to_pb_bytes();
diff --git a/src/object_store/src/object/mod.rs b/src/object_store/src/object/mod.rs
index c701a438253ae..46139804c6576 100644
--- a/src/object_store/src/object/mod.rs
+++ b/src/object_store/src/object/mod.rs
@@ -334,6 +334,10 @@ impl ObjectStoreImpl {
     pub fn support_streaming_upload(&self) -> bool {
         dispatch_object_store_enum!(self, |store| store.inner.support_streaming_upload())
     }
+
+    pub fn media_type(&self) -> &'static str {
+        object_store_impl_method_body!(self, media_type())
+    }
 }
 
 fn try_update_failure_metric<T>(