From a5b3395daee257eac940954bf1b6a3eb1a924bbb Mon Sep 17 00:00:00 2001 From: Richard Chien Date: Mon, 29 Jan 2024 16:06:15 +0800 Subject: [PATCH] allow range frame calls using range cache policies other than `full` Signed-off-by: Richard Chien --- src/stream/src/executor/over_window/general.rs | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/stream/src/executor/over_window/general.rs b/src/stream/src/executor/over_window/general.rs index e48685ca13189..df4e3ac5c84c2 100644 --- a/src/stream/src/executor/over_window/general.rs +++ b/src/stream/src/executor/over_window/general.rs @@ -171,9 +171,7 @@ impl OverWindowExecutor { .calls .iter() .any(|call| call.frame.bounds.is_unbounded()); - // TODO(rc): only support full cache for `RANGE` frame for now, for the sake of simplicity - let has_range_frame = args.calls.iter().any(|call| call.frame.bounds.is_range()); - let cache_policy = if has_unbounded_frame || has_range_frame { + let cache_policy = if has_unbounded_frame { // For unbounded frames, we finally need all entries of the partition in the cache, // so for simplicity we just use full cache policy for these cases. CachePolicy::Full