From 98e1c6479c656d011325994314abe71ffc79c83e Mon Sep 17 00:00:00 2001 From: William Wen <44139337+wenym1@users.noreply.github.com> Date: Tue, 9 Apr 2024 11:15:08 +0800 Subject: [PATCH] chore(storage): remove Sync requirement on HummockIterator (#16196) --- src/object_store/src/object/mod.rs | 2 -- src/storage/src/hummock/iterator/mod.rs | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/src/object_store/src/object/mod.rs b/src/object_store/src/object/mod.rs index a8fe659550ae9..d122a5bb37fe4 100644 --- a/src/object_store/src/object/mod.rs +++ b/src/object_store/src/object/mod.rs @@ -411,8 +411,6 @@ pub struct MonitoredStreamingReader { streaming_read_timeout: Option, } -unsafe impl Sync for MonitoredStreamingReader {} - impl MonitoredStreamingReader { pub fn new( media_type: &'static str, diff --git a/src/storage/src/hummock/iterator/mod.rs b/src/storage/src/hummock/iterator/mod.rs index 01807a451108e..83bf2de61b136 100644 --- a/src/storage/src/hummock/iterator/mod.rs +++ b/src/storage/src/hummock/iterator/mod.rs @@ -66,7 +66,7 @@ pub struct ValueMeta { /// After creating the iterator instance, /// - if you want to iterate from the beginning, you need to then call its `rewind` method. /// - if you want to iterate from some specific position, you need to then call its `seek` method. -pub trait HummockIterator: Send + Sync { +pub trait HummockIterator: Send { type Direction: HummockIteratorDirection; /// Moves a valid iterator to the next key. ///