From 4c0015fb30480d874675f145c008b24eecf5f783 Mon Sep 17 00:00:00 2001 From: Michael Xu Date: Sat, 3 Feb 2024 17:31:10 -0500 Subject: [PATCH] remove unnecessary expr in expr.proto --- proto/expr.proto | 3 --- src/frontend/src/expr/pure.rs | 1 - 2 files changed, 4 deletions(-) diff --git a/proto/expr.proto b/proto/expr.proto index e991e7f017a74..e26b725b49737 100644 --- a/proto/expr.proto +++ b/proto/expr.proto @@ -88,9 +88,6 @@ message ExprNode { // Optimize case-when expression to constant lookup // when arms are in a large scale with simple form CONSTANT_LOOKUP = 624; - // Optimized in frontend - // should be invisible to backend - CONSTANT_CASE_WHEN_EVAL = 625; // ROUND(numeric, integer) -> numeric ROUND_DIGIT = 213; // ROUND(numeric) -> numeric diff --git a/src/frontend/src/expr/pure.rs b/src/frontend/src/expr/pure.rs index 53209eedfdacb..c50f1cc2460b8 100644 --- a/src/frontend/src/expr/pure.rs +++ b/src/frontend/src/expr/pure.rs @@ -86,7 +86,6 @@ impl ExprVisitor for ImpureAnalyzer { | expr_node::Type::Rtrim | expr_node::Type::Case | expr_node::Type::ConstantLookup - | expr_node::Type::ConstantCaseWhenEval | expr_node::Type::RoundDigit | expr_node::Type::Round | expr_node::Type::Ascii