From 2e3ec9aa943ce5dd1e2b191029510e2a253e40ea Mon Sep 17 00:00:00 2001 From: Richard Chien Date: Tue, 9 Jan 2024 17:33:26 +0800 Subject: [PATCH] make from_protobuf and to_protobuf private Signed-off-by: Richard Chien --- src/common/src/util/sort_util.rs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/common/src/util/sort_util.rs b/src/common/src/util/sort_util.rs index 754d094d2eb7a..9c2a8c05b6282 100644 --- a/src/common/src/util/sort_util.rs +++ b/src/common/src/util/sort_util.rs @@ -38,7 +38,7 @@ pub enum Direction { } impl Direction { - pub fn from_protobuf(direction: &PbDirection) -> Self { + fn from_protobuf(direction: &PbDirection) -> Self { match direction { PbDirection::Ascending => Self::Ascending, PbDirection::Descending => Self::Descending, @@ -46,7 +46,7 @@ impl Direction { } } - pub fn to_protobuf(self) -> PbDirection { + fn to_protobuf(self) -> PbDirection { match self { Self::Ascending => PbDirection::Ascending, Self::Descending => PbDirection::Descending, @@ -74,7 +74,7 @@ enum NullsAre { } impl NullsAre { - pub fn from_protobuf(nulls_are: &PbNullsAre) -> Self { + fn from_protobuf(nulls_are: &PbNullsAre) -> Self { match nulls_are { PbNullsAre::Largest => Self::Largest, PbNullsAre::Smallest => Self::Smallest, @@ -82,7 +82,7 @@ impl NullsAre { } } - pub fn to_protobuf(self) -> PbNullsAre { + fn to_protobuf(self) -> PbNullsAre { match self { Self::Largest => PbNullsAre::Largest, Self::Smallest => PbNullsAre::Smallest,