From 003ac47b26b1e51db8cc2cee499e01d251f6cad9 Mon Sep 17 00:00:00 2001 From: CAJan93 Date: Mon, 15 Jul 2024 16:51:54 +0200 Subject: [PATCH] change comments --- proto/catalog.proto | 9 +++++---- proto/common.proto | 8 ++++---- proto/ddl_service.proto | 4 ++-- proto/meta.proto | 5 ++--- 4 files changed, 13 insertions(+), 13 deletions(-) diff --git a/proto/catalog.proto b/proto/catalog.proto index 656af29721a1c..efd932a23a08f 100644 --- a/proto/catalog.proto +++ b/proto/catalog.proto @@ -406,16 +406,17 @@ message Table { // notification service. TableVersion version = 100; - // If a MV/sink/table has a node_label, its actors can only be scheduled on CNs with - // that label. If a MV does not have a node_label it can be scheduled on any - // CN without a label. The node has to have both a matching key and value. + // If a materialize view, sink, or table has a node_label, its actors can only be scheduled + // on compute nodes with that label. + // If a it does not have a node_label it can be scheduled on any + // Compute node without a label. The node has to have both a matching key and value. // E.g. {"some":"value"} can be scheduled on a node with the labels // { // "other":"thing", // "some":"value" // } // but {"some":"thing"} can not be scheduled on that node. - // A MV/sink/table with an empty node_labels map can only be scheduled on nodes with + // A materialized view or sink or table with an empty node_labels map can only be scheduled on nodes with // empty node_labels map, but a node with empty node_labels can host anything. map node_labels = 101; } diff --git a/proto/common.proto b/proto/common.proto index 0c38a6a319091..5b656f48ed0f3 100644 --- a/proto/common.proto +++ b/proto/common.proto @@ -77,17 +77,17 @@ message WorkerNode { optional uint64 started_at = 9; // Meta may assign labels to worker nodes to partition workload by label. - // This is used for serverless backfilling of MVs. + // This is used for serverless backfilling of materialized views. // If a WorkerNode has labels set it indicates that this node only accepts certain work. - // If a WorkerNode has no labels set it indicates that this node only any work. - // The MV has to have both a matching key and value to be scheduled on a node. + // If a WorkerNode has no labels set it indicates that this node accepts any work. + // The materialized view has to have both a matching key and value to be scheduled on a node. // E.g. {"some":"value"} can be scheduled on a node with the labels // { // "other":"thing", // "some":"value" // } // but {"some":"thing"} can not be scheduled on that node. - // Worker nodes with an empty node_labels map can host any MV/sink/table. + // Worker nodes with an empty node_labels map can host any materialized view or sink or table. map node_labels = 10; } diff --git a/proto/ddl_service.proto b/proto/ddl_service.proto index 125b304345075..e77cb75311250 100644 --- a/proto/ddl_service.proto +++ b/proto/ddl_service.proto @@ -121,8 +121,8 @@ message CreateMaterializedViewRequest { catalog.Table materialized_view = 1; stream_plan.StreamFragmentGraph fragment_graph = 2; - // If SERVERLESS, the MV should be created using serverless backfill - // For that the controller will create a new CN, which does backfilling and then is deleted. + // If SERVERLESS, the materialized view should be created using serverless backfill + // For that the controller will create a new compute node, which does backfilling and then is deleted. // May alleviate pressure on the cluster during backfill process. enum BackfillType { REGULAR = 0; diff --git a/proto/meta.proto b/proto/meta.proto index a387736a3fc41..23f1c4c975c2e 100644 --- a/proto/meta.proto +++ b/proto/meta.proto @@ -546,14 +546,13 @@ message TableParallelism { } } -// overwrite the MV/table/sink with the given id +// overwrite the materialized view/table/sink with the given id // Change a streaming job in place. You cannot use this to create a new streaming job message UpdateStreamingJobRequest { - // Id of the MV or sink which we want to update + // Id of the materialized view, table, or sink which we want to update uint32 id = 1; oneof streaming_job { - // the new MV or table catalog.Table table = 2; catalog.Sink sinks = 3; }