Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do nn upsample before mel condition #8

Open
liuhuang31 opened this issue Dec 16, 2021 · 0 comments
Open

do nn upsample before mel condition #8

liuhuang31 opened this issue Dec 16, 2021 · 0 comments

Comments

@liuhuang31
Copy link

liuhuang31 commented Dec 16, 2021

for generator code line 137:

if i >= self.cond_level: 
                mel = self.cond_up[i - self.cond_level](mel)
                x += mel
if i > self.cond_level:
    if output is None:
        output = self.res_output[i - self.cond_level - 1](x)
    else:
        output = self.res_output[i - self.cond_level - 1](output)

in the code, for the nn upsample input is: mel condition + resblock output.

image

but in the paper, nn upsample input only is resblock output or the last nn upsample output;

image

so, Is this more reasonable?

if i > self.cond_level:
    if output is None:
        output = self.res_output[i - self.cond_level - 1](x)
    else:
        output = self.res_output[i - self.cond_level - 1](output)
if i >= self.cond_level: 
                mel = self.cond_up[i - self.cond_level](mel)
                x += mel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant