Skip to content
This repository has been archived by the owner on Mar 20, 2024. It is now read-only.

Clarify how the largest element index is determined #876

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hdelassus
Copy link
Contributor

Fixes #873

v-spec.adoc Outdated
the current `vtype` setting is reserved.
The use of `vstart` values greater than the largest element index is reserved.
The largest element index is determined using the effective element width and
effective group multiplier of the current instruction.
Copy link
Collaborator

@aswaterman aswaterman Apr 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will create confusion since each operand of an instruction can have a different EEW and EMUL. Maybe something like "the EEW and EMUL of the instruction's widest operand". It's true that whether you pick the widest or narrowest operand doesn't matter, since the EEW:EMUL ratio is the same... I'm just trying to figure out how to phrase it to minimize the number of questions we'll get.

Copy link
Contributor Author

@hdelassus hdelassus Apr 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "the EEW and EMUL of any vector operand"?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... does the "any vector operand" approach lead to confusion around mask operands? Suppose we have SEW=8 LMUL=1/8 and the instruction is masked. If we say that EEW:EMUL ratio is the same for all operands, that would imply the mask operand (which has EEW=1) has EMUL=1/64. That might be definitionally true, but since normally we don't talk about LMUL < 1/8, it could lead to additional confusion.

Does "the EEW and EMUL of the instruction's widest vector operand" avoid that concern without introducing any additional definitional problems?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the case of mask logical instructions, the widest operand is a mask. What is the EEW or EMUL of a mask operand?

In this case, I think the intent is that EEW = EMUL = 1, but I can't find any text that supports that unambiguously.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For mask-logical instructions, the existing text (respect vtype) does the right thing.

I'm starting to wonder if we should leave the text as-is, instead calling out the special cases where it doesn't apply (whole-register loads/stores/moves).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm starting to wonder if we should leave the text as-is, instead calling out the special cases where it doesn't apply (whole-register loads/stores/moves).

It may be easier to understand, yeah.

But EMUL=1/64 for mask operands doesn't sound confusing to me. After all, EEW=1 is clearly not a supported SEW, and yet it is used in the text. It's "effectively" 1/64 sometimes.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, valid point.

When I have some spare time, I'll try writing up my alternative version, and we can decide which is easier to understand.

@hdelassus hdelassus force-pushed the clarify-largest-element-for-vstart branch from 9af95c8 to 917d4e7 Compare April 18, 2023 21:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Largest element index is vague
3 participants