Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation out of date #660

Open
jordancarlin opened this issue Dec 31, 2024 · 5 comments
Open

Documentation out of date #660

jordancarlin opened this issue Dec 31, 2024 · 5 comments

Comments

@jordancarlin
Copy link
Collaborator

The ExtendingGuide in docs/ has fallen pretty far out of date. It refers to files that no longer exist (riscv_csr_ext.sail, riscv.sail, etc.), outdated virtual memory functions (checkPTEPermission), and uses the N extension as its example, which is no longer in the model.

There are also several newer things that are required to add a new extension that are not covered in the guide, like the extensionEnabled enum.

@jordancarlin
Copy link
Collaborator Author

The ReadingGuide has similar issues with broken links and references to nonexistent files.

@Timmmm
Copy link
Collaborator

Timmmm commented Dec 31, 2024

Yeah I vote to just remove them. This sort of documentation always falls out of date in my experience. It stands a much better chance as comments in the code. Maybe some of the content could be translated to comments.

@jordancarlin
Copy link
Collaborator Author

I was leaning towards removing them as well, but wasn’t sure if people thought it was worth maintaining the Extending Guide as a way for new contributors to get started adding extensions. That being said, I don’t think I looked at it when I was getting going so not sure how useful it really is.

@billmcspadden-riscv
Copy link
Collaborator

billmcspadden-riscv commented Jan 1, 2025 via email

@jordancarlin jordancarlin added the tgmm-agenda Tagged for the next Golden Model meeting agenda. label Jan 2, 2025
@jordancarlin
Copy link
Collaborator Author

Per discussion during today's meeting, we are going to keep the documentation because we think it is still worthwhile to new contributors and users.

I will add a warning to the documentation for now to warn users that it is not up to date and will start to work through updating parts of it that are obviously wrong.

@edolnx is going to look at tooling to help notify us when the documentation falls out of date and potentially to extract some of it directly from the code.

@Timmmm Timmmm removed the tgmm-agenda Tagged for the next Golden Model meeting agenda. label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants