Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to landscape2 #639

Open
tegioz opened this issue Feb 1, 2024 · 19 comments
Open

Migration to landscape2 #639

tegioz opened this issue Feb 1, 2024 · 19 comments
Assignees

Comments

@tegioz
Copy link

tegioz commented Feb 1, 2024

Hi! 👋

We've been working on a new version of the landscape generating software, landscape2. The CNCF landscape has already been successfully migrated to v2, and we'd like to start migrating more landscapes.

I understand that RISC-V landscape users prefer v1 (which is fine and cool). But we'd appreciate if you could give us some feedback and share some more details about missing features in landscape2 that would make the migration easier for you 🙂

Please note that the RISC-V landscape built with v2 is outdated, as there is a small change required in the landscape.yml file that's blocking the build. #629 fixes it -and it's backwards compatible with v1-, so it'd be great if you could merge with when you have a chance. Thanks!

@tegioz
Copy link
Author

tegioz commented Feb 1, 2024

Thanks for merging #629! https://riscv.landscape2.io should now be up to date.

@hythloda
Copy link
Member

hythloda commented Nov 6, 2024

@tegioz the RISC-V landscape built with v2 is outdated still. Is there something we need to do to keep up up-to-date?

@tegioz
Copy link
Author

tegioz commented Nov 6, 2024

Hi @hythloda 👋

We paused its build some time ago because it was raising errors due to some problems in the landscape.yml file. But we've just resumed it and it should be up to date now (it'll be built daily going forward) 🙂

@hythloda
Copy link
Member

hythloda commented Nov 7, 2024

Thanks for the daily build! We have it up on a test webpage

https://riscv.org/members2-3/

The errors in the landscape.yml took a while to fix ;)

@tegioz
Copy link
Author

tegioz commented Nov 7, 2024

Awesome, no problem!

@hythloda
Copy link
Member

I am trying to understand where the RISC-V landscape2 is built. Since it is being built daily I expected the logos for Akeana and Tencent to be replaced but it doesn't seem like it has yet.
https://github.com/riscv-admin/riscv-landscape/pull/703/files - shows new logos for a few orgs
https://riscv.landscape2.io/?group=members - showing old logos for the ones added.

Thanks for helping us learn!

@tegioz
Copy link
Author

tegioz commented Nov 11, 2024

Hi @hythloda

The PR you referenced (#703) seems to be closed, it wasn't merged. If you merge it into the main branch, the next landscape build should use the new logos.

@hythloda
Copy link
Member

Thanks! I merged the one for today. The build breaks so I was hesitant to merge. I can't seem to get the build to work this time because of a duplicate Org (have a ticket to the LFX team to resolve it) I merged but hope it doesn't break something :)

@tegioz
Copy link
Author

tegioz commented Nov 11, 2024

Ok, cool 👍

Please note that all the Netlify stuff only refers to the v1 of the landscape. I'd recommend you to add this validation workflow to ensure that the landscape.yml file remains valid before merging a PR. It that validation doesn't pass, it's likely that the changes will break the v2 build.

@hythloda
Copy link
Member

The updates are happening now. Thanks for the workflow. Is there any tweaking of images we need to do? For example Akeana's SVG seems to not have much whitespace
https://github.com/riscv-admin/riscv-landscape/blob/main/hosted_logos/akeana.svg

Screenshot 2024-11-12 at 8 48 55 AM

However in the landscape2 it seems to have more white space
Screenshot 2024-11-12 at 8 47 10 AM

@tegioz
Copy link
Author

tegioz commented Nov 13, 2024

Hi @hythloda

During the landscape v2 build process, we try to make some adjustments to logos to make them fit their box better. However, sometimes this process doesn't help at all, making things worse. In those case, we can exclude certain logos from this extra processing. So we've excluded this one and it should look better now 🙂

@hythloda
Copy link
Member

hythloda commented Dec 5, 2024

There are a few logos in https://riscv.landscape2.io/?group=members that Calista noted need some work. How can we get those fixed?
For example a few include

  • Morse Micro Pty. Ltd (member)
  • RIVAI Technologies (Shenzhen) Co., Lt
  • Chengdu Qunxin Microelectronics Tech
  • Vision Microsystems (Shanghai), Co.
  • Beijing Academy of Blockchain and Ed
  • University of Engineering and Technology Taxila (member)
  • Veer Surendra Sai University of

@cynthia-sg
Copy link
Contributor

Hi @hythloda,

We have created a PR to update these logos.

We have updated the color for Morse Micro and we get a new one for Veer Surendra Sai University. For the rest, we have used the logo from the cached_logo directory.

If you need to fix more logos you only have to update them on the hosted_logos directory (the landscape is deployed automatically once a day).

Thanks!

@hythloda
Copy link
Member

Hi @hythloda,

We have created a PR to update these logos.

We have updated the color for Morse Micro and we get a new one for Veer Surendra Sai University. For the rest, we have used the logo from the cached_logo directory.

If you need to fix more logos you only have to update them on the hosted_logos directory (the landscape is deployed automatically once a day).

Thanks!

Thanks for the fix. It would be nice to have an automated way since the images are pulled from PCC each night and the ones in hosted_logos are overridden.

@tegioz
Copy link
Author

tegioz commented Dec 10, 2024

Thanks for the fix. It would be nice to have an automated way since the images are pulled from PCC each night and the ones in hosted_logos are overridden.

In that case, it'd probably be best if you could update that source with the correct logos, so that they propagate automatically. The landscape will be generated daily with the logos available in the hosted_logos directory.

@hythloda
Copy link
Member

hythloda commented Jan 7, 2025

We are noticing that one member "Centre for Development of Advanced Computing (C-DAC)" is still listed in strategic and community. The landscape is pulling correctly and they are only in strategic. Is there something we need to do to remove them from community?

@hythloda
Copy link
Member

hythloda commented Jan 7, 2025

@tegioz

Thank you so much for all your support. We have updated the information on LFx and Crunchbase for Andes Tech. However, the RISC-V Landscape (link) did not seem to update with the employee count or info from crunchbase. Is there a way to update this autopulled information?

The LinkedIn link is incorrect. The correct link should be: https://www.linkedin.com/company/13688177/.
Our employee count should be in the range of 500-1000.
Our stock exchange is TWSE, and the ticket number is 6533.
andes

@tegioz
Copy link
Author

tegioz commented Jan 7, 2025

No worries @hythloda 🙂

C-DAC: it looks like that entry was removed yesterday. The RISCV landscape is built once a day, you can check previous builds here. Next one is about to start within the next couple of hours I think. Then, the landscape may still be cached for up to one hour. So you should see your changes pretty soon 🙂

Data coming from Crunchbase, however, is cached for a little longer, and it may take up to a week to refresh (depending on the last time we pulled it, but a maximum of one week in the worst case).

@hythloda
Copy link
Member

hythloda commented Jan 7, 2025

WOO! Crunchbase timeline is good to know! much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants