Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Set timeout for HTTP uploads #41

Open
blackandred opened this issue Feb 4, 2023 · 2 comments
Open

Set timeout for HTTP uploads #41

blackandred opened this issue Feb 4, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@blackandred
Copy link
Contributor

In case, when the server will not be responding we need to set a timeout on client side.

Case:

  • Storage backend went down, so the server's readiness was unhealthy
  • In meantime the client was uploading, the job hanged for 10 hours
@blackandred blackandred self-assigned this Feb 4, 2023
@blackandred
Copy link
Contributor Author

I suggest also to add a client-side verification of the server before starting the upload. The could be a server endpoint to verify client supplied authorization, write access and possibility to perform the backup at all.

That would be an additional layer of protection against weird cases, and would increase clarity - as the client would be able to know what is going on.

Example messages returned back:

  • "The server is unhealthy"
  • "Access denied"
  • "Not enough disk space" (the last one may not be possible to implement due to backend storage abstraction, but lets check it)

@blackandred blackandred added the bug Something isn't working label Feb 4, 2023
@blackandred
Copy link
Contributor Author

Related issue #48

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant