Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Statistics/Overall Season/UI] Use the Service Functions to Dynamically Update the Aggregated Seasonal Stats #89

Closed
Trim0500 opened this issue Mar 15, 2024 · 1 comment · Fixed by #119 or #129 · May be fixed by #171
Closed
Assignees
Labels
enhancement New feature or request Overall Season (Group #8) Specific tasks related to overall season statistics services Statistics Tasks related to statistics service functions

Comments

@Trim0500
Copy link
Collaborator


Feature Request

  • As a user uses OpenTracks to collect more data, the stats that are calculated via the service functions change over time. When the user goes to check their All-Time stats, this fact is an expectation by the user and so should be represented on the aggregated seasonal stats page.

Proposed Solution

  • When using the callback functions to render the page, the service functions developed should be called to get the data to then pas it along to the page.

Alternatives

  • Create some variables that store the calculated values and are simply reused onto the page when it must be rendered. This may allow for the numbers to be calculated after the completion of a new run but this form of eager loading may cause increased complexity & effort and could waste some computational time as the user may/may not actually view the all-time stats.

Completeness Requirements

  • The service functions meant to calculate the aggregated seasonal stats are called when rendering the page
  • The rendered numbers are accurate to the calculation
  • When adding in new tracks, the stats are updated and changed

Additional context

#7

@Trim0500 Trim0500 added enhancement New feature or request Statistics Tasks related to statistics service functions Overall Season (Group #8) Specific tasks related to overall season statistics services labels Mar 15, 2024
@Trim0500
Copy link
Collaborator Author


  • Since the other groups have yet to establish what kinds of functions and data are available to us, mockup data used here to illustrate the idea for overall stats. I will close down this issue and any further work should be carried out onto a new issue once all the details have been ironed out.

@Trim0500 Trim0500 linked a pull request Mar 25, 2024 that will close this issue
Trim0500 added a commit that referenced this issue Mar 25, 2024
---
## Context
- Seeking to add in some implementations for generating reports of
All-Time overall ski stats
- A new page has been added, accessible through the aggregated stats
page
- A new class has been added in using a singleton pattern to encapsulate
all-time overall ski stats
- An OSM dashboard integration has been added, accessible from the new
page to push these stats

## Issue Links
- #85 
- #86 
- #87 
- #88 
- #89 
---
@Trim0500 Trim0500 mentioned this issue Mar 25, 2024
@Trim0500 Trim0500 linked a pull request Mar 25, 2024 that will close this issue
Trim0500 added a commit that referenced this issue Mar 25, 2024
---
### Description
- Seeking to add in some rudimentary overall ski stats implementations
into main

### Issue Links
- #85 
- #86 
- #87 
- #88 
- #89 
- #21 
---
@Kpytoo Kpytoo linked a pull request Apr 7, 2024 that will close this issue
Picard4 added a commit that referenced this issue Apr 29, 2024
Pushing Group 14's changes into main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Overall Season (Group #8) Specific tasks related to overall season statistics services Statistics Tasks related to statistics service functions
Projects
None yet
2 participants