usedImages May be Empty When Using Windows

[jeremy-harnois]

The use of '/' with _().split() doesn't always split file paths properly on Windows. This results in usedImages being empty and all images being deleted. I believe using path.sep would be better.

[PostmanZero]

Hey, do you have any solution for that?

[rickysullivan]

I'll take a look soon. Haven't used this package (or gulp) in a number of years.

[PostmanZero]

Thank you, I'm looking forward to it!

[PostmanZero]

So I can replace '/' with path.sep and the deletion of files will work on Widows?
return _.includes(usedImageNames, _(path).split('/').last());

[jeremy-harnois]

I ultimately didn't use this plugin because I also ran in to #10, so I don't have a working project using path.sep to confirm. But IIRC—and there's only one split()—yes, that's the change.

[rickysullivan]

I haven't had the time to spin up a new project. I tried adding some basic unit tests to the repo. But I have no idea how to test gulp. The idea was to use the tests to assert these use cases and to modify the source against the tests.

[PostmanZero]

Cramp replacement
return _.includes(usedImageNames, _(path).split('/').last());
on
return _.includes(usedImageNames, _(path).split(path.sep).last());
still delete all images. I don't know what else to do and need this removal mechanism. :/

[PostmanZero]

Okay, looks like it works like this on Windows:
return _.includes(usedImageNames, _(path).split('/').last());
on
return _.includes(usedImageNames, _(path).split('\\' || '/').last());
Can anyone confirm that it will also work on macOS?

[jeremy-harnois]

/ should work across platforms. I wonder if lodash is messing with things somehow.

still delete all images

My reference to path.sep is a link to Node's path API. In this particular instance, there's already a path variable from the enclosing function's arguments, so you can't just use path.sep without some additional work like require()ing that API.

Can anyone confirm that it will also work on macOS?

It's unlikely since '\\' || '/' will always return '\\' because it's not falsey.