Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove event handler for NetworkChange.NetworkAddressChanged #106

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

schotime
Copy link

@schotime schotime commented Jun 5, 2021

Fixes #99

@codecov-commenter
Copy link

Codecov Report

Merging #106 (84d5db7) into master (b9f2f81) will decrease coverage by 0.56%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #106      +/-   ##
==========================================
- Coverage   91.11%   90.55%   -0.57%     
==========================================
  Files          10       10              
  Lines         518      519       +1     
==========================================
- Hits          472      470       -2     
- Misses         46       49       +3     
Impacted Files Coverage Δ
src/MulticastService.cs 91.62% <100.00%> (+0.04%) ⬆️
src/MulticastClient.cs 82.78% <0.00%> (-2.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9f2f81...84d5db7. Read the comment docs.

@schotime schotime force-pushed the patch-1 branch 2 times, most recently from 4a69eaa to e78234b Compare June 5, 2021 04:35
@schotime schotime changed the title Remove event handler for NetworkChange.NetworkAddressChanged when Stopping #99 Remove event handler for NetworkChange.NetworkAddressChanged Jun 5, 2021
@jdomnitz
Copy link

This PR was merged into the fork available here:
https://github.com/jdomnitz/net-mdns

Also available as a Nuget package:
Makaretu.Dns.Multicast.New

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory leak in MulticastService
3 participants