Skip to content
This repository has been archived by the owner on Oct 14, 2022. It is now read-only.

Use constants for scoped variables in JS functions #7

Open
nesk opened this issue Jun 20, 2018 · 0 comments
Open

Use constants for scoped variables in JS functions #7

nesk opened this issue Jun 20, 2018 · 0 comments
Labels
breaking changes The API will break if this issue or pull request is approved
Milestone
v2.0.0

Comments

@nesk
Copy link
Member

nesk commented Jun 20, 2018

Currently, the scoped variables in JS functions are assignable. There is no reason to allow this behavior, the const keyword should used instead of var in scoped variable declarations:

https://github.com/nesk/rialto/blob/21a21181249ca0c09268c84fc93e2650849a37f1/src/node-process/Data/Unserializer.js#L48
@nesk nesk added the breaking changes The API will break if this issue or pull request is approved label Jun 20, 2018
@nesk nesk added this to the v2.0.0 milestone Jun 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
breaking changes The API will break if this issue or pull request is approved
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
1 participant
@nesk