Skip to content
This repository has been archived by the owner on Oct 14, 2022. It is now read-only.

Remove the JsFunction::create method #6

Open
nesk opened this issue Jun 20, 2018 · 0 comments
Open

Remove the JsFunction::create method #6

nesk opened this issue Jun 20, 2018 · 0 comments
Labels
breaking changes The API will break if this issue or pull request is approved
Milestone
v2.0.0

Comments

@nesk
Copy link
Member

nesk commented Jun 20, 2018 •
edited
Loading

Once the create method has been deprecated and Rialto is ready for a new major release, the former should be removed from the library.

Requires method chaining to be implemented.
Remember to remove the deprecated docs.
@nesk nesk added the breaking changes The API will break if this issue or pull request is approved label Jun 20, 2018
@nesk nesk changed the title Remove the create() static method from the JsFunction class Remove the JsFunction::create method Jun 20, 2018
@nesk nesk added this to the v2.0.0 milestone Jun 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
breaking changes The API will break if this issue or pull request is approved
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
1 participant
@nesk